Prevent Pre-Publish Panel from Displaying Incorrect Information After Navigating away #67010
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sarthaknagoshe2002! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
| ( prevProps.isPublished && | ||
| ! this.props.isSaving && | ||
| this.props.isDirty ) || | ||
| ! this.props.postlink |
There was a problem hiding this comment.
I think a better check would be to see if the currentPostId changed: this.props.currentPostId !== prevProps.currentPostId, where currentPostId is select(editorStore).getCurrentPostId().
There was a problem hiding this comment.
Hey @ntsekouras, thanks for suggesting a better approach!
I have implemented the suggested changes, please have a look.
Thanks 🙌🏻
There was a problem hiding this comment.
Thank you! Let's use getCurrentPostId selector though instead of getEditedPostAttribute( 'id' ) and name the prop currentPostId for clarity.
There was a problem hiding this comment.
@ntsekouras I have implemented the changes!
Also, can you highlight on why using getCurrentPostId is a better approach?
Thanks 🙌🏻
There was a problem hiding this comment.
Sure. Since we only want the id, getCurrentPostId returns that directly from the state whereas getEditedPostAttribute is a doing more and we don't need to fetch all the edits etc..
ntsekouras
added
[Type] Bug
…f getEditedPostAttribute
Fixes: #64913
What?
This PR addresses a bug highlighted in #64913 where the pre-publish panel displays incorrect or broken information when switching to edit a template part. Specifically, if you open the pre-publish checks and immediately switch to edit a template part, the panel continues to show details about the template part, instead of closing or updating appropriately.
Why?
This fix improves the user experience by preventing confusion caused by incorrect information in the pre-publish panel. It ensures the behavior aligns with expectations, where the pre-publish is closed when navigating away.
How?
The issue is resolved by ensuring that when the user navigates away from editing the page, the pre-publish panel is closed. This change ensures that the publish flow is not interrupted and the pre-publish checks are only shown for the current page or post, not the template part.
Testing Instructions
publishto open the pre-publish panelScreenshots or screencast
pre-publish.panel.bug.mov